Skip to content

fix(NcPasswordField): reset validation on change#8350

Merged
Antreesy merged 2 commits into
mainfrom
fix/noid/password-validate
Mar 25, 2026
Merged

fix(NcPasswordField): reset validation on change#8350
Antreesy merged 2 commits into
mainfrom
fix/noid/password-validate

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

☑️ Resolves

🖼️ Screenshots

2026-03-24_18h09_20

🚧 Tasks

  • do we need to emit something on reset? Or let app devs handle it?

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

- tests given payload length only

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 9.6.0 milestone Mar 24, 2026
@Antreesy Antreesy self-assigned this Mar 24, 2026
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Mar 24, 2026
@codecov

codecov Bot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.41%. Comparing base (6eec54e) to head (9a9ae60).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/components/NcPasswordField/NcPasswordField.vue 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8350      +/-   ##
==========================================
+ Coverage   52.37%   52.41%   +0.04%     
==========================================
  Files         104      104              
  Lines        3393     3396       +3     
  Branches      989      988       -1     
==========================================
+ Hits         1777     1780       +3     
  Misses       1360     1360              
  Partials      256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy Antreesy force-pushed the fix/noid/password-validate branch from 5b92733 to e312d2d Compare March 24, 2026 17:54
Comment thread src/components/NcPasswordField/NcPasswordField.vue Outdated
- do not send a request on empty field

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/password-validate branch from e312d2d to 9a9ae60 Compare March 24, 2026 19:48

@DorraJaouad DorraJaouad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Antreesy Antreesy merged commit d57b6bf into main Mar 25, 2026
27 checks passed
@Antreesy Antreesy deleted the fix/noid/password-validate branch March 25, 2026 16:24
@Antreesy

Copy link
Copy Markdown
Contributor Author

/backport to stable8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: input-field Covering the InputField, TextField, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[23.0.2] usability flaw when saving password for conversation

3 participants