fix(NcCheckboxRadioSwitch): use reactive state for group checkbox toggle#8324
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8324 +/- ##
==========================================
+ Coverage 52.37% 53.01% +0.63%
==========================================
Files 104 104
Lines 3393 3388 -5
Branches 989 989
==========================================
+ Hits 1777 1796 +19
+ Misses 1360 1344 -16
+ Partials 256 248 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ad4c4a0 to
66b3d55
Compare
The array/group checkbox path in onToggle read input.checked from the DOM via getInputsSet(). On keyboard spacebar, the browser toggles input.checked before firing the change event, so the DOM-read logic inverted the intended action and emitted the stale modelValue. Replace DOM queries with reactive-state reads (this.isChecked and this.internalModelValue) which correctly reflect the pre-toggle state regardless of the event source. Fixes #8321 Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
66b3d55 to
513cd21
Compare
susnux
approved these changes
Mar 24, 2026
Contributor
|
/backport to stable8 |
skjnldsv
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
N/A - behavioral fix, no visual change
🚧 Tasks
getInputsSet()) with reactive state reads inonToggle🏁 Checklist
stable8for maintained Vue 2 version or not applicable