fix(NcRichContenteditable): restore native undo/redo events#8286
Merged
Conversation
a78deab to
4431475
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8286 +/- ##
==========================================
- Coverage 52.75% 52.65% -0.10%
==========================================
Files 103 103
Lines 3361 3373 +12
Branches 980 984 +4
==========================================
+ Hits 1773 1776 +3
- Misses 1337 1345 +8
- Partials 251 252 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fe119ee to
04208d7
Compare
Contributor
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
reviewed
Mar 10, 2026
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
approved these changes
Mar 11, 2026
DorraJaouad
approved these changes
Mar 11, 2026
- Setting `contenteditable` to `plaintext-only` allows to avoid custom paste handling logic instead of manually inserted text nodes, which prevented the browser from tracking history for undo/redo operations - Fallback kept for Firefox 135 and older to ensure component isn't broken when setting unknown attribute value Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
55b85ce to
4b037c0
Compare
susnux
approved these changes
Mar 11, 2026
Contributor
Author
|
/backport to stable8 |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
@Antreesy Backport? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
contenteditabletoplaintext-onlyallows to get rid of custom paste handling logic instead of manually inserted text nodes, which prevented the browser from tracking history for undo/redo operations🖼️ Screenshots
🏚️ Before
2026-03-09_22h02_42.mp4
🏡 After
2026-03-09_22h00_54.mp4
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable