[stable8] fix(NcModal): properly handle modal name size#8268
Merged
Conversation
9d1b165 to
7b3909e
Compare
- When the width is small the name must be ellipsed and not overflow any action (e.g. the play buttton!). - The name must be centered if wide enough (it was not because padding was incorrectly calculated). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
7b3909e to
0f41f5f
Compare
susnux
reviewed
Mar 2, 2026
Comment on lines
+689
to
+701
| showCloseButton() { | ||
| if (this.noClose) { | ||
| return false | ||
| } | ||
| return this.canClose | ||
| }, | ||
|
|
||
| isCloseButtonOutside() { | ||
| if (this.closeButtonOutside) { | ||
| return true | ||
| } | ||
| return !this.closeButtonContained | ||
| }, |
Contributor
There was a problem hiding this comment.
In stable8 there was a small other bug where the logic did not trigger if you set closeButtonOutside it was not shown outside otherwise
susnux
approved these changes
Mar 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8268 +/- ##
===========================================
- Coverage 45.74% 45.69% -0.05%
===========================================
Files 193 193
Lines 4864 4878 +14
Branches 1254 1197 -57
===========================================
+ Hits 2225 2229 +4
- Misses 2551 2563 +12
+ Partials 88 86 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cristianscheid
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8263
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.