Skip to content

fix(NcButton): remove active effect from disabled buttons#8176

Merged
susnux merged 1 commit into
mainfrom
fix/noid/disabled-styles
Feb 6, 2026
Merged

fix(NcButton): remove active effect from disabled buttons#8176
susnux merged 1 commit into
mainfrom
fix/noid/disabled-styles

Conversation

@Antreesy

@Antreesy Antreesy commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Fix style artifact from clicking a disabled button

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy
fix(NcButton): remove active effect from disabled buttons
6e26d80 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 9.5.1 milestone Feb 6, 2026
@Antreesy Antreesy self-assigned this Feb 6, 2026
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: button labels Feb 6, 2026
@Antreesy

Antreesy commented Feb 6, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable8

@codecov

codecov Bot commented Feb 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.82%. Comparing base (9a72e5b) to head (6e26d80).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8176   +/-   ##
=======================================
  Coverage   52.82%   52.82%           
=======================================
  Files         103      103           
  Lines        3351     3351           
  Branches      976      977    +1     
=======================================
  Hits         1770     1770           
  Misses       1333     1333           
  Partials      248      248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux merged commit 6ed0b36 into main Feb 6, 2026
27 checks passed
@susnux susnux deleted the fix/noid/disabled-styles branch February 6, 2026 12:51
@backportbot backportbot Bot mentioned this pull request Feb 6, 2026
Merged
@susnux susnux modified the milestones: 9.5.1, 9.6.0 Feb 7, 2026
@susnux susnux mentioned this pull request Mar 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews bug Something isn't working feature: button

Projects

None yet

Milestone

9.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @susnux @ShGKme