Skip to content

feat: add new border design for NcInputField and NcTextArea#7351

Merged
susnux merged 3 commits into
mainfrom
feat/nc-32-input-borders
Aug 26, 2025
Merged

feat: add new border design for NcInputField and NcTextArea#7351
susnux merged 3 commits into
mainfrom
feat/nc-32-input-borders

Conversation

@susnux

@susnux susnux commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2025-08-21 at 19-01-55 Nextcloud Vue Style Guide Screenshot 2025-08-21 at 19-01-16 Nextcloud Vue Style Guide
Screenshot 2025-08-21 at 19-01-49 Nextcloud Vue Style Guide Screenshot 2025-08-21 at 19-01-28 Nextcloud Vue Style Guide

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@susnux susnux added this to the 9.0.0-rc.7 milestone Aug 21, 2025
@susnux susnux requested review from CarlSchwan, kra-mo and st3iny August 21, 2025 17:12
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: input-field Covering the InputField, TextField, ... labels Aug 21, 2025
@susnux

susnux commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

/backport to stable8

kra-mo

This comment was marked as resolved.

@kra-mo

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@susnux susnux marked this pull request as draft August 22, 2025 10:58
@susnux susnux added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 22, 2025
@susnux

This comment was marked as resolved.

@kra-mo

This comment was marked as resolved.

@kra-mo

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@susnux susnux force-pushed the feat/nc-32-input-borders branch from fa6171d to 110349c Compare August 22, 2025 12:26
@susnux

susnux commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

@kra-mo what do you think about this solution? (Input fields only not the textarea)

@susnux susnux force-pushed the feat/nc-32-input-borders branch from 110349c to e4b9a42 Compare August 22, 2025 12:56
@kra-mo

kra-mo commented Aug 22, 2025

Copy link
Copy Markdown
Member

@kra-mo what do you think about this solution? (Input fields only not the textarea)

Really nice! :)

@susnux susnux requested a review from kra-mo August 22, 2025 15:34
@susnux susnux marked this pull request as ready for review August 22, 2025 15:34

@kra-mo kra-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! You even fixed the jumping that was there previously, really nice!

Just one small thing: the order of the shadows is inconsistent between text fields and areas. For areas, the stronger border ends on the outside and for fields, the inside.

If this is not easily fixable, no problem. But if it is, the order used for fields surprisingly looks more natural and I'd adapt that for areas too.

@susnux susnux force-pushed the feat/nc-32-input-borders branch from a5bbaaf to 14329dc Compare August 23, 2025 17:29
@susnux

susnux commented Aug 23, 2025

Copy link
Copy Markdown
Contributor Author

If this is not easily fixable, no problem. But if it is, the order used for fields surprisingly looks more natural and I'd adapt that for areas too.

Sure adjusted the textarea to the inputfield look :)

@susnux susnux force-pushed the feat/nc-32-input-borders branch from 14329dc to dea7f49 Compare August 25, 2025 13:36
susnux added 2 commits August 26, 2025 10:55
- resolves #7221

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/nc-32-input-borders branch from dea7f49 to 5ff2cad Compare August 26, 2025 08:56

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in preview and app

@susnux

susnux commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

/update-snapshots

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit ab127ff into main Aug 26, 2025
25 checks passed
@susnux susnux deleted the feat/nc-32-input-borders branch August 26, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress design Design, UX, interface and interaction design enhancement New feature or request feature: input-field Covering the InputField, TextField, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NcFields] Adjust border styling

4 participants