Skip to content

feat(NcPopover): document all properties and remove transparent floating-vue wrapper#6802

Merged
susnux merged 1 commit into
mainfrom
feat/nc-popover
Apr 25, 2025
Merged

feat(NcPopover): document all properties and remove transparent floating-vue wrapper#6802
susnux merged 1 commit into
mainfrom
feat/nc-popover

Conversation

@susnux

@susnux susnux commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

☑️ Resolves

  1. Document all properties used by Nextcloud apps (I checked for all usage in the nextcloud GitHub organization)
  2. Remove mention of the wrapped library
  3. Add feature to use logical direction in the placement prop

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: popover Related to the popovermenu component 💥 breaking PR that requires a new major version labels Apr 17, 2025
@susnux susnux added this to the v9.0.0-rc.0 milestone Apr 17, 2025
@susnux susnux requested a review from ShGKme April 17, 2025 16:09

@ShGKme ShGKme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked only bidi part yet

Comment thread src/components/NcPopover/NcPopover.vue Outdated
Comment thread src/components/NcPopover/NcPopover.vue Outdated
Comment thread src/components/NcPopover/NcPopover.vue Outdated
@susnux susnux force-pushed the feat/nc-popover branch 3 times, most recently from a626f5a to be765e6 Compare April 20, 2025 10:13
@susnux susnux removed the 💥 breaking PR that requires a new major version label Apr 20, 2025
@susnux susnux changed the title feat(NcPopover)!: document all properties and remove transparent floating-vue wrapper feat(NcPopover): document all properties and remove transparent floating-vue wrapper Apr 20, 2025
@susnux susnux requested review from Antreesy, ShGKme and st3iny April 24, 2025 08:33
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread src/components/NcPopover/NcPopover.vue Outdated
Comment thread src/components/NcPopover/NcPopover.vue Outdated
- Also support RTL design

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: popover Related to the popovermenu component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Last call for @nextcloud/vue v9 breaking changes

4 participants