[next] refactor(NcDateTimePicker): migrate to @vuepick library#6651
Conversation
0b0dca4 to
8cbcade
Compare
8cbcade to
01ac292
Compare
| &--highlighted { | ||
| opacity: .7; | ||
| .dp__btn.dp__button.dp__button_bottom { | ||
| inset-block-end: 6px; |
There was a problem hiding this comment.
Can we have this 6px computed?
| .v-popper--theme-dropdown.v-popper__popper.timezone-select__popper .v-popper__wrapper { | ||
| border-radius: var(--border-radius-large); | ||
| :deep(.dp__btn.dp__button.dp__overlay_action) { | ||
| width: calc(100% - 16px); |
| padding-inline-start: var(--dp-input-icon-padding) !important; | ||
| } | ||
| :deep(.dp__btn) { | ||
| padding: calc((var(--default-clickable-area) - 20px) / 2); |
There was a problem hiding this comment.
20px = the icon size we passed as prop to the icon wrapper
9dd5055 to
8cc7ebb
Compare
Antreesy
left a comment
There was a problem hiding this comment.
Tested
Please fix typo at L11: - cleareable: false
dbbdbc5 to
b1384b8
Compare
|
Nice. |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
b1384b8 to
a2479aa
Compare
It is the same component, but by bad API design too much was (indirectly) exposed. If there is a feature missing we should instead add a prop our own and wrap this internally instead of exposing it. |
|
I have to try it, but I hacked around the underlying library, to get the functionality like I needed it. I fear, the component in Polls will behave deferentially, causing a lot of coding and testing. I would be fine with having the component under a different name to have enough time to make sure, it does not break Polls. |
Please open a feature request if you find something missing, we will add it |
|
Do you plan a new alpha release for v9 or when is the RC to expect? |
@vuepick library@vuepick library
|
/backport to stable8 |
|
The backport to # Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/6651/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a2479aab
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6651/stable8Error: Failed to check for changes with origin/stable8: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Yes, we plan RC soon. v9 branch is no the |
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade