[next] fix!: make 'box-sizing: border-box' a default behaviour for all containers#6390
Merged
Conversation
4 tasks
susnux
approved these changes
Jan 16, 2025
susnux
left a comment
Contributor
There was a problem hiding this comment.
Makes sense but did not check all components
ShGKme
reviewed
Jan 16, 2025
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
nitpick: deep does nothing to universal selector * in Vue 3, it is never scoped.
…iners Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
298add1 to
00a1be5
Compare
Contributor
|
cc @dartcafe to know about the change |
ShGKme
approved these changes
Jan 17, 2025
Contributor
|
Thanks, I already watched this topic, since I believe it may solve an actual problem I have with the NcModal. At least I hope. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@nextcloud/vue v9breaking changes #6384🖼️ Screenshots
Apart from NcPopover, there should be no visual changes from this PR
🏁 Checklist
nextrequested with a Vue 3 upgrade