fix: parse node and npm version from package.json#72
Merged
Conversation
09755f5 to
a016a0a
Compare
artonge
approved these changes
Oct 21, 2025
Contributor
|
Other solutions would be to either:
Or am I missing something? |
Contributor
Author
For node I already created a PR month ago, but it will not fix the npm installation - that action is only about Node.js not about the package manager.
Sure, but I would rather move it into our org. |
This uses the `engines`, `devEngines` or `packageManager` fields of the `package.json` to properly setup the environment. Its required as `setup-node` does not yet know about `devEngines` and also does not setup the package manager - and never will. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
a016a0a to
8193d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the
engines,devEnginesorpackageManagerfields of thepackage.jsonto properly setup the environment.Its required as
setup-nodedoes not yet know aboutdevEnginesand also does not setup the package manager - and never will.Details
Now resolved:
Important⚠️
Before merging: If accepted I would transfer the action for parsing into this organization so everyone can contribute and its not owned by a single person.