Skip to content

[stable1.0] Fix ownership#2576

Merged
samin-z merged 12 commits into
stable1.0from
backport/2574/stable1.0
May 6, 2026
Merged

[stable1.0] Fix ownership#2576
samin-z merged 12 commits into
stable1.0from
backport/2574/stable1.0

Conversation

@backportbot

@backportbot backportbot Bot commented May 6, 2026

Copy link
Copy Markdown

Backport of #2574

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot Bot requested review from benjaminfrueh and samin-z May 6, 2026 14:48
@backportbot backportbot Bot added the 3. to review Waiting for reviews label May 6, 2026
@backportbot backportbot Bot added this to the v2.1.0 milestone May 6, 2026
@samin-z samin-z marked this pull request as ready for review May 6, 2026 16:59
@samin-z samin-z requested review from blizzz and enjeck as code owners May 6, 2026 16:59
Comment thread lib/Service/ShareService.php Outdated
$item->setLastEditAt($time->format('Y-m-d H:i:s'));

if ($shareToken) {
$item->setToken((string)$shareToken);

@benjaminfrueh benjaminfrueh May 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In both stable0.9 and stable1.0 this should throw an error because token and setToken() does not exist there in the Share entity, it was added in version 2.0 with the addition of public link shares.

The added ShareToken.php in the backports, should also not be necessary.

samin-z added 12 commits May 6, 2026 21:49
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z samin-z force-pushed the backport/2574/stable1.0 branch from d0ee1da to b2798b4 Compare May 6, 2026 19:51
@samin-z samin-z merged commit e236dc0 into stable1.0 May 6, 2026
63 of 65 checks passed
@samin-z samin-z deleted the backport/2574/stable1.0 branch May 6, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants