📍Option to pin a column#2496
Merged
Merged
Conversation
8d95bd6 to
a5b68d7
Compare
enjeck
reviewed
Apr 23, 2026
enjeck
left a comment
Contributor
There was a problem hiding this comment.
I'll wait for designers to review first before I do
a5b68d7 to
0bd6aec
Compare
Member
Author
|
@enjeck designers, namely @marcoambrosini are fine with it 😃 👍 |
AI-assistant: Claude Code v2.1.114 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.114 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.114 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.114 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.114 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.114 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.114 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.119 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
0bd6aec to
499c770
Compare
enjeck
approved these changes
Apr 26, 2026
enjeck
left a comment
Contributor
There was a problem hiding this comment.
works well, thanks. Just nitpicking:
| box-shadow: inset -1px 0 0 var(--color-border-dark); | ||
| } | ||
|
|
||
| // Visual separator on the last frozen column � 2px overrides the 1px per-column border above. |
Contributor
There was a problem hiding this comment.
malformed character (�). Also, i don't think all the comments are helpful anyway
Comment on lines
+32
to
+45
| * Returns a sticky-positioning style for a column within the frozen range, or null if it should scroll normally. | ||
| * | ||
| * columnWidths is an optional map of col.id → measured offsetWidth (px). When supplied it is used for the | ||
| * left-offset calculation so the offsets match the browser's actual auto-layout widths. Without it the | ||
| * calculation falls back to customSettings.width or DEFAULT_COLUMN_WIDTH. | ||
| * | ||
| * No explicit width is set on the frozen cell itself — the table's auto-layout already maintains the | ||
| * correct column width across all rows. Forcing a width here caused auto-sized columns to be narrowed | ||
| * to the DEFAULT_COLUMN_WIDTH fallback. | ||
| * | ||
| * Hidden columns are excluded from visibleColumns before this function is called, so pinnedColumnIndex | ||
| * naturally resolves to -1 when the pinned column is hidden, causing the freeze to silently disappear. | ||
| * This is intentional: when the pinned column is re-shown the freeze resumes automatically. | ||
| */ |
Contributor
There was a problem hiding this comment.
Comment is too long and not helpful, imo, could be removed
Member
Author
|
I'll take care of the comments @enjeck - thanks for the review 🙏 |
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements the column aspect of #613 - frontend-only (not persisted in the backend in any way - also currently not planned to, see below).
So this is not persisted in any way to keep the PR simple. Storing the info could be a follow-up, question would be the scope, general or per user while I think pinning is in most cases something temporary or general so I am unsure about a user option.
For general pinning it should then just happen via the dialog not in the tabular view itself I think.
❓ Open Question
Should the pinned column be more visually marked as such, see below. Currently the column line is thicker, but that is the only way to spot the pinned column and of course it becomes apparent upon horizontal scrolling. Can't tell given that spreadsheets also don't visualize it, but the thought crossed my mind, so I wanted to bring it up. Below "Ease of use" is the pinned column (see the slightly thickened column line)