Skip to content

Add possibility filter select/multiselect columns with dropdown#2387

Merged
enjeck merged 1 commit into
mainfrom
feature/add-filtering-by-selection
May 5, 2026
Merged

Add possibility filter select/multiselect columns with dropdown#2387
enjeck merged 1 commit into
mainfrom
feature/add-filtering-by-selection

Conversation

@Koc

@Koc Koc commented Mar 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Right now it is not possible to to search select/multiselect columns using OR operator (contains "aaa" or "bbb") using plain text filters. This PR adds possibility to filter select/multiselect with droprowns instead of plain text. Also it can be useful for large tables when you don't know full list of possible dropdown values

🔍 Preview

This is how it works now
image

This is how it works with patch
image
image
image

@Koc Koc requested review from blizzz and enjeck as code owners March 11, 2026 10:23
@EEngl52

EEngl52 commented Mar 12, 2026

Copy link
Copy Markdown

Thanks a lot for this new feature! Do I understand it correctly that this expands the filter options within a particular view (i.e. on view level)?
Would it be possible to extend the filter options even further to app level, so you could filter all views within a tables app simultaneously? The existing filter option is very helpful to quickly find the relevant rows within a view. When you have a tables app with several views and the relevant information is spread over all of them, it is rather tedious and annoying that you have to filter all of them separately. Having a joint search on app-level would improve usability immensely for us.

@Koc Koc force-pushed the feature/add-filtering-by-selection branch from c058042 to 26767b9 Compare March 15, 2026 22:10
@Koc Koc mentioned this pull request Mar 15, 2026
Merged
Koc
Koc commented Apr 1, 2026
View reviewed changes
Comment thread src/shared/components/ncTable/sections/CustomTable.vue Outdated
@AndyScherzinger AndyScherzinger added enhancement New feature or request 3. to review Waiting for reviews labels Apr 12, 2026
@AndyScherzinger AndyScherzinger changed the title Feat: Add possibility filter select/multiselect columns with dropdown Add possibility filter select/multiselect columns with dropdown Apr 12, 2026
@samin-z samin-z self-requested a review April 14, 2026 11:56
@Koc Koc force-pushed the feature/add-filtering-by-selection branch from 26767b9 to 02c666c Compare April 15, 2026 21:47
@enjeck enjeck force-pushed the feature/add-filtering-by-selection branch from 6922ae9 to 730e920 Compare April 23, 2026 17:08
enjeck
enjeck reviewed Apr 24, 2026
View reviewed changes

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few tiny comments

Comment thread src/shared/components/ncTable/partials/TableHeaderColumnOptions.vue Outdated
Comment thread src/shared/components/ncTable/partials/FilterLabel.vue Outdated
@enjeck enjeck force-pushed the feature/add-filtering-by-selection branch from 730e920 to 9bfccf3 Compare April 24, 2026 03:44
@Koc Koc force-pushed the feature/add-filtering-by-selection branch 2 times, most recently from ce9f3ff to e0ac0d3 Compare April 26, 2026 17:13
@Koc

Koc commented Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

@enjeck everything fixed, pipeline is green. I have no idea what can block us from merging that 😄

@Koc Koc force-pushed the feature/add-filtering-by-selection branch from e0ac0d3 to 44a7308 Compare April 26, 2026 18:16
@Koc
Feat: Add possibility filter select/multiselect columns with dropdown
c6e12b0 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/add-filtering-by-selection branch from 44a7308 to c6e12b0 Compare April 26, 2026 18:20
enjeck
enjeck approved these changes May 5, 2026
View reviewed changes

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@enjeck enjeck merged commit e612fa9 into main May 5, 2026
56 checks passed
@enjeck enjeck deleted the feature/add-filtering-by-selection branch May 5, 2026 05:24
@Koc Koc mentioned this pull request Jun 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enjeck enjeck enjeck approved these changes

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

@samin-z samin-z Awaiting requested review from samin-z

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Koc @EEngl52 @enjeck @samin-z @AndyScherzinger