Client-side only enforcement of textMaxLength#2348
Merged
Conversation
Contributor
Author
|
/backport! to stable1.0 |
2 tasks
blizzz
approved these changes
Mar 2, 2026
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
98dcf04 to
c5bbda0
Compare
enjeck
reviewed
Mar 3, 2026
| } | ||
|
|
||
| foreach ($data as $entry) { | ||
| $column = $columnsById[$entry['columnId']]; |
Contributor
There was a problem hiding this comment.
What if it's an invalid columnId? Then $columnsById[$entry['columnId']] won't exist and $column null? Which breaks validateColumnValueLimits()?
Contributor
There was a problem hiding this comment.
maybe moving validateColumnValueLimits() into cleanupAndValidateData() is more robust
Contributor
Author
There was a problem hiding this comment.
@enjeck good point, cleaned up unnecessary checks.
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend enforcement of textMaxLength, Min and Max values for table cells.