refactor: Refactor business column classes#2284
Merged
Merged
Conversation
e4b7806 to
b7d99fc
Compare
b7d99fc to
01cde46
Compare
blizzz
reviewed
Feb 24, 2026
blizzz
left a comment
Member
There was a problem hiding this comment.
Thanks! Good PR! 🙂
Two minor remarks, and two nitpicks that would not be blocking.
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
01cde46 to
45e4920
Compare
Contributor
Author
|
@blizzz fixed all your comments 😇 |
blizzz
approved these changes
Feb 24, 2026
Member
Thank you 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColumnsHelper::getColumnBusiness()instead of duplication:ImportService::parseValueByColumnType()RowService::getColumnBusiness()SuperBusinessnow implementsIColumnTypeBusiness$columnnon-nullable in a column business classes and remove redundant checks. I can't find any use-case when it can be nullable