Skip to content

Conversation

@MorrisJobke
Copy link
Member

Before:

bildschirmfoto 2018-11-15 um 12 18 52
bildschirmfoto 2018-11-15 um 12 18 58


After:

bildschirmfoto 2018-11-15 um 12 18 00

bildschirmfoto 2018-11-15 um 12 15 05

Hovered:
bildschirmfoto 2018-11-15 um 12 15 09

@nextcloud/designers Have a look. I know it involves a lot of CSS fiddling, but I don't want to completely reorder the DOM structure as of now.

* does not hide thumbnail when rename is shown
* fixes layout for grid and list view
* fixes #11901

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to do the trick! Quick smoke tests shows it works

@MorrisJobke MorrisJobke merged commit 790ee0c into master Nov 15, 2018
@ChristophWurst ChristophWurst deleted the bugfix/11901/show-thumbnail-on-rename branch November 15, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File renaming should not vanish the filetype icon / preview

5 participants