Skip to content

fix: dismiss notifications. #9222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
camilasan merged 2 commits into from
Dec 11, 2025
Merged

fix: dismiss notifications. #9222

camilasan merged 2 commits into from
Dec 11, 2025

Conversation

@camilasan
Copy link
Member

@camilasan camilasan commented Dec 10, 2025

Fix for #6797 and #8274.

Displays the notication with the option to dismiss it:

Screenshot 2025-12-10 at 15 46 43

It sends delete action to server, removing the notification from the list:

Screenshot 2025-12-10 at 15 48 00

@camilasan camilasan added this to the 4.0.4 milestone Dec 10, 2025
@camilasan
Copy link
Member Author

camilasan commented Dec 10, 2025

/backport to stable-4.0

@camilasan
Copy link
Member Author

camilasan commented Dec 10, 2025

/backport to stable-3.17

This was linked to issues Dec 10, 2025
Dismiss or mark notifications as readed via nextcloud client and/or windows taskbar notification area #6797
Closed
Provide a way to permanently dismiss particular server announcements #8274
Closed
@camilasan camilasan force-pushed the bugfix/noid/notifications branch from 94d7f88 to 2cf120c Compare December 10, 2025 17:49
@camilasan camilasan enabled auto-merge December 10, 2025 17:50
@camilasan @mgallien
style: modernize ServerNotificationHandler::slotNotificationsReceived.
173a234 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @mgallien
fix(notifications): add delete action to notifications.
7315ea6 
Fix for #6797 and #8274.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@mgallien mgallien force-pushed the bugfix/noid/notifications branch from 2cf120c to 7315ea6 Compare December 11, 2025 08:15
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9222.zip

Digest: sha256:240c525903a658bc02f22adce728068721d1ef117168ec8c4bc7f03828b22c09

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@camilasan camilasan merged commit 232b474 into master Dec 11, 2025
20 of 22 checks passed
@camilasan camilasan deleted the bugfix/noid/notifications branch December 11, 2025 09:08
This was referenced Dec 11, 2025
Merged
Merged
@mgallien mgallien modified the milestones: 4.0.4, 4.1.0 Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.0

4 participants

@camilasan @nilsding @mgallien