fix(migration): return correct migration state if no accounts were found. #9190
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable-4.0 |
Member
Author
|
/backport to stable-3.17 |
nilsding
approved these changes
Dec 9, 2025
…und. The migration success dialog was being displayed even when there was no legacy configuration to migrate from. Signed-off-by: Camila Ayres <hello@camilasan.com>
bd22165 to
d646474
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9190.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This was referenced Dec 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration success dialog was being displayed even when there was no legacy configuration to migrate from.
I added some more checks before concluding that any migration was done.
The only users who would see the dialog are users setting up the client for the first time.
Afterwards the client would function normally.