Skip to content

fix(filesystem/win32): make use of long paths where possible #9077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 4 commits into from
Nov 17, 2025
Merged

fix(filesystem/win32): make use of long paths where possible #9077

mgallien merged 4 commits into from
Nov 17, 2025
+45 −27

Conversation

@nilsding
Copy link
Member

@nilsding nilsding commented Nov 17, 2025

This PR includes a couple of changes:

  • FileSystem::setFileReadOnly now makes use of long Windows paths
  • same for c_utimes (used by FileSystem::setModTime), i.e. setting the modtime on longer paths now works as well (the Windows variant of csync_vio_local_stat already did that)
  • use QString::utf16 instead of creating a temporary std::wstring
  • replaced one usage of GetFileAttributes with GetFileAttributesW

@nilsding
style(filesystembase): use explicit *W function variant
f5dd55a 
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding
fix(filesystem): use UNC paths in setFileReadOnly
1f5d8a5 
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding
fix(win32): ensure setting modtime works on longer path
ce200f5 
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding
refactor(filesystem): use QString::utf16 instead of creating a tempor…
7a1e8fa 
…ary std::wstring

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding nilsding added this to the 4.0.2 milestone Nov 17, 2025
@nilsding
Copy link
Member Author

nilsding commented Nov 17, 2025

/backport to stable-4.0

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9077.zip

Digest: sha256:00d64eff6c7b9205d913a62b993bdb4ad403f5e02a541d496ff3c7e6c7c0a4e4

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 17, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 6e621f4 into master Nov 17, 2025
21 of 22 checks passed
@mgallien mgallien deleted the bugfix/noid/max-path branch November 17, 2025 15:22
@backportbot backportbot bot mentioned this pull request Nov 17, 2025
Merged
@nilsding nilsding mentioned this pull request Nov 18, 2025
Open
8 tasks
@nilsding nilsding linked an issue Nov 18, 2025 that may be closed by this pull request
[Bug]: Subfolders are recreated constantly #9036
Open
8 tasks
@mgallien mgallien modified the milestones: 4.0.2, 4.1.0 Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgallien mgallien mgallien approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Subfolders are recreated constantly

3 participants

@nilsding @mgallien