fix(file-provider): Existing Lock Comparison #9062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
881e8cc to
b5dbbc0
Compare
Collaborator
Author
|
/backport to stable-4.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9062.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
- Some time ago, I implemented the token based locks. In scope of that I temporarily changed the "lock" property to a complex type before reverting it. I probably forgot to turn back the changes here which compare the property like it is an optional struct even though it is a boolean. - Improved code formatting and updated some calls to use asynchronous methods of NextcloudKit directly without continuations. - Set the key equivalent of the close button to the escape key. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
b5dbbc0 to
e2b35a7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9059 being merged first.