fix(log): Re-establish connection for systray mono icons #9050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log: > 2025-11-13 13:38:51:420 [ warning qt.core.qobject.connect unknown:0 ]: QObject::connect(OCC::NextcloudTheme, Unknown): invalid nullptr parameter Moved the Theme::systrayUseMonoIconsChanged hookup until after the GUI object is created so Qt no longer warns about connecting NextcloudTheme signals to a null receiver. Signed-off-by: Rello <Rello@users.noreply.github.com>
|
Artifact containing the AppImage: nextcloud-appimage-pr-9050.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
nilsding
approved these changes
Nov 13, 2025
Member
nilsding
left a comment
There was a problem hiding this comment.
thanks! this actually fixes a bug too -- now the monochrome icon switch happens immediately
Member
|
/backport to stable-4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log:
Moved the Theme::systrayUseMonoIconsChanged hookup until after the GUI object is created so Qt no longer warns about connecting NextcloudTheme signals to a null receiver.