chore(vfs/windows): test migration from VFS to classic sync on windows #9020
Conversation
610c427 to
e5ee1aa
Compare
e5ee1aa to
bb6083f
Compare
fd57893 to
385aeb3
Compare
| QVERIFY(itemInstruction(completeSpy, "directory", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "firstFile1.txt", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "firstFile2.txt", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "firstFile3.txt", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "directory/subdir", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "directory/file1", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "directory/file2", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "directory/file3", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "directory/subdir/fileTxt1.txt", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "directory/subdir/fileTxt2.txt", CSYNC_INSTRUCTION_NEW)); | ||
| QVERIFY(itemInstruction(completeSpy, "directory/subdir/fileTxt3.txt", CSYNC_INSTRUCTION_NEW)); |
There was a problem hiding this comment.
might be worth to verify the item direction as well to catch potential regressions early enough
There was a problem hiding this comment.
yes
this is a good idea
let me work on a follow up PR to add such a check (where it would make sense)
|
/backport to stable-4.0 |
385aeb3 to
099a397
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
when we switch back to classic, all virtual items have to be deleted to get back to a clean state virtual folders would have been left as is causing issues Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
099a397 to
ac4698d
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9020.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Close #8953