Skip to content

fix(discovery): display more user friendly message when data is missing from server response. #8982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 2 commits into from
Nov 14, 2025
Merged

fix(discovery): display more user friendly message when data is missing from server response. #8982

mgallien merged 2 commits into from
Nov 14, 2025

Conversation

@camilasan
Copy link
Member

@camilasan camilasan commented Oct 29, 2025 •
edited
Loading

before - "Server reported no ETag":
Bildschirmfoto 2025-10-27 um 16 39 53

after:
Screenshot 2025-11-03 at 10 41 31

@camilasan camilasan added this to the 4.1.0 milestone Oct 29, 2025
@camilasan
Copy link
Member Author

camilasan commented Oct 29, 2025

/backport to stable-4.0

@camilasan camilasan requested a review from Rello October 29, 2025 15:50
@camilasan
Copy link
Member Author

camilasan commented Oct 29, 2025 •
edited
Loading

  • alternatively us: "File or folder not accessible on the server".
    waiting for feedback from the server engineers.

@camilasan camilasan marked this pull request as draft October 29, 2025 16:05
@camilasan camilasan marked this pull request as ready for review November 3, 2025 09:44
@camilasan camilasan modified the milestones: 4.1.0, 4.0.2 Nov 3, 2025
@mgallien mgallien enabled auto-merge November 3, 2025 14:09
@camilasan camilasan force-pushed the bugfix/missingetag branch 2 times, most recently from 703ca40 to d8f744d Compare November 14, 2025 13:17
@camilasan
fix(discovery): display more user friendly message when data is missi…
e2a7cb1 
…ng from server response.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(test): update error string expected when etga is missing.
b1e2800 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8982.zip

Digest: sha256:d4ad36a20a6910bc9618f37df0aec43ca16aac60c078e2a19aa6c9acf7d365da

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit c1ee1a8 into master Nov 14, 2025
20 checks passed
@mgallien mgallien deleted the bugfix/missingetag branch November 14, 2025 13:55
@backportbot backportbot bot mentioned this pull request Nov 14, 2025
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
56 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@camilasan
Copy link
Member Author

camilasan commented Nov 17, 2025

/backport to stable-3.17

@backportbot backportbot bot mentioned this pull request Nov 17, 2025
Merged
@mgallien mgallien modified the milestones: 4.0.2, 4.1.0 Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

@Rello Rello Awaiting requested review from Rello

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@camilasan @nilsding @mgallien