Skip to content

fix(account): do not consider URLs with a trailing slash as public links #8932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsding merged 1 commit into from
Oct 23, 2025
Merged

fix(account): do not consider URLs with a trailing slash as public links #8932

nilsding merged 1 commit into from
Oct 23, 2025

Conversation

@nilsding
Copy link
Member

@nilsding nilsding commented Oct 23, 2025

Resolves #8929

@nilsding
fix(account): do not consider URLs with a trailing slash as public links
bddb39d 
Resolves #8929

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding nilsding self-assigned this Oct 23, 2025
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8932.zip

Digest: sha256:542953a429408628d38153278af7e334a8d141638d72c30f0a7733366c13d456

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding mentioned this pull request Oct 23, 2025
Closed
8 tasks
@nilsding
Copy link
Member Author

nilsding commented Oct 23, 2025

/backport to stable-4.0

@nilsding nilsding added this to the 4.1.0 milestone Oct 23, 2025
@nilsding nilsding enabled auto-merge October 23, 2025 10:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
33 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nilsding nilsding merged commit 06b87b6 into master Oct 23, 2025
21 of 23 checks passed
@nilsding nilsding deleted the bugfix/8929/fileshare-detection branch October 23, 2025 11:50
@backportbot backportbot bot mentioned this pull request Oct 23, 2025
Merged
@camilasan
Copy link
Member

camilasan commented Nov 17, 2025

/backport to stable-3.17

@backportbot
Copy link

backportbot bot commented Nov 17, 2025

The backport to stable-3.17 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.17
git pull origin stable-3.17

# Create the new backport branch
git checkout -b backport/8932/stable-3.17

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bddb39df

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8932/stable-3.17

Error: Failed to check for changes with origin/stable-3.17: No changes found in backport branch

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilasan camilasan camilasan approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

Assignees

@nilsding nilsding

Labels

backport-request

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Public link detection matches any URL containing /s/

3 participants

@nilsding @camilasan