Skip to content

fix(build): allow building on macOS Tahoe #8774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsding merged 1 commit into from
Sep 19, 2025
Merged

fix(build): allow building on macOS Tahoe #8774

nilsding merged 1 commit into from
Sep 19, 2025

Conversation

@nilsding
Copy link
Member

@nilsding nilsding commented Sep 19, 2025

@i2h3 please give this a try on macOS 26

@nilsding
fix(build): allow building on macOS Tahoe
9d74744 
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8774.zip

Digest: sha256:9e4fce63f57c70ed07b91a14a4d86e777fee4d17b19e710d22be096172cade52

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@i2h3 i2h3 requested a review from Copilot September 19, 2025 07:41
Copilot AI reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a CMake Find module to wrap OpenGL linking in a way compatible with newer macOS (“Tahoe”) by avoiding AGL and ensuring relocatable framework linkage.

  • Adds FindWrapOpenGL.cmake that creates WrapOpenGL::WrapOpenGL and handles Apple vs non-Apple linking.
  • Implements Apple-specific logic to use framework-style linking; provides a Linux fallback for X11-less systems.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

i2h3
i2h3 approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@i2h3 i2h3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not completely understood it yet but it works. 😁

@nilsding
Copy link
Member Author

nilsding commented Sep 19, 2025

/backport to stable-3.17

@nilsding nilsding merged commit 78cc252 into master Sep 19, 2025
19 of 20 checks passed
@nilsding nilsding deleted the work/noid/tahoe-compat branch September 19, 2025 08:44
@backportbot backportbot bot mentioned this pull request Sep 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mgallien mgallien mgallien approved these changes

@i2h3 i2h3 i2h3 approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nilsding @mgallien @i2h3