fix(syncstatussummary): do not attempt to fetch VFS state for accounts without VFS enabled #8763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport! to stable-3.17 |
…s without VFS enabled The socket server won't ever know anything about accounts that are not set up with VFS, resulting in a "Some files could not be synced" warning message. There is no use in trying to fetch the state in that case. Since the state of the File Provider is per-account, iterating over all accounts is not necessary either. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
0d6816e to
554a284
Compare
mgallien
approved these changes
Sep 17, 2025
|
Artifact containing the AppImage: nextcloud-appimage-pr-8763.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket server won't ever know anything about accounts that are not set up with VFS, resulting in a "Some files could not be synced" warning message. There is no use in trying to fetch the state in that case.
Since the state of the File Provider is per-account, iterating over all accounts is not necessary either.
Resolves #8683