Skip to content

Conversation

@mgallien
Copy link
Collaborator

config.h has a constant for the application name, use this everywhere in user facing messages

@mgallien mgallien added this to the 3.18.0 milestone Sep 15, 2025
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall, thanks!

config.h has a constant for the application name, use this everywhere in
user facing messages

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
this is indeed not the desktop main window but the content area of the
cleint main window

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/useApplicationName branch from 33329de to 9d4209f Compare September 15, 2025 14:18
@mgallien mgallien enabled auto-merge September 15, 2025 14:18
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-8746.zip

Digest: sha256:403277e4a9cd0c34d9506fbd6341ef05461c417205a60bc58a4160e0e0aea3a3

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit e1bec57 into master Sep 15, 2025
17 checks passed
@mgallien mgallien deleted the bugfix/useApplicationName branch September 15, 2025 14:53
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
36 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@camilasan
Copy link
Member

/backport to stable-3.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants