Skip to content

fix(ActivityList): attach vertical scrollbar, having minimum width and thumbsize, to the right of the traymenu #8690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 3 commits into from
Sep 5, 2025
Merged

fix(ActivityList): attach vertical scrollbar, having minimum width and thumbsize, to the right of the traymenu #8690

mgallien merged 3 commits into from
Sep 5, 2025

Conversation

@barisbasar1209
Copy link
Contributor

@barisbasar1209 barisbasar1209 commented Sep 2, 2025 •
edited
Loading

This PR aims to resolve the discussion pertaining to issue #5536. Authors are @mike0609king and me. Thanks a lot for the reviews!

Previously:

Though most of the original problems mentioned in this thread seem to have been resolved, there appeared to be a remaining dissatisfaction with the usability of the ActivityList's Scrollbar among users. From what we were able to extract from the discussion this mainly stems from the fact that

  • (mainly on windows11) the ScrollBar is quite slim,
  • it's thumb can get really small and
  • then also having to hover over this small area for the ScrollBar to appear.

Changes:

  • The ScrollBar is attached to the right of the traymenu. This resembles the style that can be found in many other desktop applications like webbrowsers, the Windows file explorer,VS Code and Discord.
  • The ScrollBar is given a minimum width, which is approximately the same as in the Universal style (windows10 style).
  • The ScrollBar's thumb's minimum size is set to 0.03

Images:

Windows10:
image

Windows11:
image

We are aware that these changes might not be wanted. However, as described in the beginning, from our understanding this seemed to be a way to improve the user experience.
Also, the minimum thumb size should already be implicitly implemented as the traymenu should only show a finite number of activities. Still we figured that it would be good to directly set it in order to guarantee for a sufficiently large thumb, independent of the activity list's length.

In any case it should be possible to close issue #5536 , right?

@mgallien
Copy link
Collaborator

mgallien commented Sep 3, 2025

looks good code wise
@kra-mo what do you think design wise ?
@barisbasar1209 can you provide a screenshot before and after the changes ?
I guess windows 11 is enough (windows 10 will be out of support anyway and people should not use it for security purposes)

@kra-mo
Copy link
Member

kra-mo commented Sep 4, 2025

From the screenshots, it looks fine to me.

@mike0609king
Copy link
Contributor

mike0609king commented Sep 4, 2025 •
edited
Loading

@mgallien
Before. If we didn't hover over the scrollbar, then it looks as follows
image
The above is also the case, if we scroll down; the scrollbar is also not visible in that case. If we hover over the scrollbar, then we see
image
The scrollbar in this case is also a bit small, therefore the width has also been increased.

After. Regardless whether we hover or don't hover the scrollbar, it is visible regardless.
image

Changes. To point out the changes again

  • Making scrollbar always visible
  • Increase the width of the scrollbar (relative to window width)

EDIT: Typo

@mgallien mgallien added this to the 3.18.0 milestone Sep 5, 2025
@mgallien mgallien enabled auto-merge September 5, 2025 08:50
@barisbasar1209 @mgallien
fix(AcitivityList): fix scrollbar on the right
9e6a8d7 
Co-authored-by: Mike Mengjie Huang <mike0609king@gmail.com>

Signed-off-by: Baris <basar.baris1209@gmail.com>
@barisbasar1209 @mgallien
fix(ActivityList): set minimum width and thumb-size for vertical Scro…
e596b26 
…llBar

Signed-off-by: Baris <basar.baris1209@gmail.com>
@barisbasar1209 @mgallien
refactor: introduce minimumScrollBarWidth and minimumScrollBarThumbSi…
e1fc7e8 
…ze as part of the style

Signed-off-by: Baris <basar.baris1209@gmail.com>
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8690.zip

Digest: sha256:aa62b826f8ab2c3bcfd653691563b465bff68b2a29a37e60dfe5db453b1a3f8f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 8a15d95 into nextcloud:master Sep 5, 2025
15 of 16 checks passed
@joshtrichards joshtrichards mentioned this pull request Sep 11, 2025
Closed
8 tasks
@nilsding
Copy link
Member

nilsding commented Sep 12, 2025

/backport to stable-3.17

@backportbot backportbot bot mentioned this pull request Sep 12, 2025
Merged
@github-actions
Copy link

github-actions bot commented Sep 17, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

No one assigned

Labels

3. to review feedback-requested

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@barisbasar1209 @mgallien @kra-mo @mike0609king @nilsding