Skip to content

Conversation

@mgallien
Copy link
Collaborator

No description provided.

@mgallien mgallien added this to the 3.18.0 milestone Aug 28, 2025
originally using qFatal or qCFatal should have written a crash dump log
file

bring it back and ensure the crash would happen via the default Qt log
message handler

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
no need to carry some hack when we can use the same standard and cross
platform feature directly from Qt code

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/crashDumpLogOnFatalLogs branch from ec67fe0 to 88f1fe1 Compare August 28, 2025 21:15
@mgallien mgallien enabled auto-merge August 28, 2025 21:15
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-8667.zip

Digest: sha256:18399e534f9e01d9f3ccfa349d60ec0fac53ffc82bd7defe41f6ec52c973d3b8

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 14b2657 into master Aug 28, 2025
17 checks passed
@mgallien mgallien deleted the bugfix/crashDumpLogOnFatalLogs branch August 28, 2025 21:46
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
64 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien
Copy link
Collaborator Author

/backport to stable-3.17

@camilasan
Copy link
Member

/backport to stable-3.17

@backportbot
Copy link

backportbot bot commented Nov 17, 2025

The backport to stable-3.17 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.17
git pull origin stable-3.17

# Create the new backport branch
git checkout -b backport/8667/stable-3.17

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a4263b73 7774f575 88f1fe1a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8667/stable-3.17

Error: Failed to check for changes with origin/stable-3.17: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants