Skip to content

Conversation

@barisbasar1209
Copy link
Contributor

This PR adresses issue #8479. I figured the only thing really that had to be done was changing the spinBox minimum from 30 to 5 seconds, as the original poster of the issue had already pointed out.

The comment behind the macro DEFAULT_REMOTE_POLL_INTERVAL in configfile.cpp appeared redundant to me, so I removed it. I hope that's alright.

Thanks for reviewing!

Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!

… 30 to 5 seconds, to align with configfile

Signed-off-by: Baris <basar.baris1209@gmail.com>
@nilsding nilsding added this to the 3.18.0 milestone Aug 25, 2025
@nilsding
Copy link
Member

/backport to stable-3.17

@nilsding nilsding enabled auto-merge August 25, 2025 06:22
@nilsding nilsding disabled auto-merge August 25, 2025 07:01
@nilsding nilsding merged commit 583928a into nextcloud:master Aug 25, 2025
13 of 18 checks passed
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nilsding
Copy link
Member

/backport to stable-3.17

@backportbot
Copy link

backportbot bot commented Sep 12, 2025

The backport to stable-3.17 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.17
git pull origin stable-3.17

# Create the new backport branch
git checkout -b backport/8641/stable-3.17

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 404723e4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8641/stable-3.17

Error: Failed to check for changes with origin/stable-3.17: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nilsding
Copy link
Member

ah, already got backported :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Configuration screen does not allow setting polling interval to less than 30 seconds

2 participants