-
Notifications
You must be signed in to change notification settings - Fork 912
fix(generalsettings): change remote pollinterval spinBox-minimum from 30 to 5 seconds, to align with configfile #8641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution!
… 30 to 5 seconds, to align with configfile Signed-off-by: Baris <basar.baris1209@gmail.com>
|
/backport to stable-3.17 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
/backport to stable-3.17 |
|
The backport to # Switch to the target branch and update it
git checkout stable-3.17
git pull origin stable-3.17
# Create the new backport branch
git checkout -b backport/8641/stable-3.17
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 404723e4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8641/stable-3.17Error: Failed to check for changes with origin/stable-3.17: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
ah, already got backported :) |
This PR adresses issue #8479. I figured the only thing really that had to be done was changing the spinBox minimum from 30 to 5 seconds, as the original poster of the issue had already pointed out.
The comment behind the macro
DEFAULT_REMOTE_POLL_INTERVALinconfigfile.cppappeared redundant to me, so I removed it. I hope that's alright.Thanks for reviewing!