fix(macOS): report Success as the initial sync state for VFS
#8573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable-3.17 |
i2h3
approved these changes
Aug 14, 2025
If only VFS sync is configured, the sync state would be stuck to `SyncPrepare` otherwise, unless a file is downloaded/uploaded from the configured VFS directory. I think this broke with ee3ae98, where the EnumerationListener that reported the sync states got removed. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
16e62cd to
ae65270
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8573.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
Hey! Wanted to see if this fixes this ? My status has been stuck on this and does not change. Running on 3.17.0 Stable Looks like i dose but wanted to ask if you don't mind :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync state would be stuck with
SyncPrepareafter VFS was initialised otherwise.This resulted in the systray icon displaying the Syncing icon when the app is launched until a file got down/uploaded from the configured VFS directory.
I think this broke with ee3ae98, that commit removed the EnumerationListener which reported the sync state while items were being enumerated.