Skip to content

fix(appimage): move VFS plugins to AppDir #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 1 commit into from
May 6, 2025
Merged

fix(appimage): move VFS plugins to AppDir #8217

mgallien merged 1 commit into from
May 6, 2025

Conversation

@nilsding
Copy link
Member

@nilsding nilsding commented Apr 28, 2025

This allows the AppImage build to find and load the experimental VFS plugins, and not crash with:

[ critical plugins /home/user/src/common/vfs.cpp:250 ]: Could not load plugin: not existent or bad metadata "nextclouddevsync_vfs_suffix"
[ fatal default /home/user/src/gui/folderman.cpp:326 ]: Could not load plugin
[1]    72936 IOT instruction (core dumped)  ./nextclouddev-master-x86_64.AppImage

Fixes #7135
Fixes #7194
Fixes #7465

@nilsding nilsding added this to the 3.17.0 milestone Apr 28, 2025
@nilsding nilsding self-assigned this Apr 28, 2025
This was referenced Apr 30, 2025
Closed
Closed
Closed
@nilsding @mgallien
fix(appimage): move VFS plugins to AppDir
c498cdb 
This allows the AppImage build to find and load the experimental VFS
plugins, and not crash with:

    [ critical plugins /home/user/src/common/vfs.cpp:250 ]: Could not load plugin: not existent or bad metadata "nextclouddevsync_vfs_suffix"
    [ fatal default /home/user/src/gui/folderman.cpp:326 ]: Could not load plugin
    [1]    72936 IOT instruction (core dumped)  ./nextclouddev-master-x86_64.AppImage

Fixes #7135
Fixes #7194
Fixes #7465

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@mgallien mgallien force-pushed the bugfix/bundle-vfs-plugins-in-appimage branch from d6e8c27 to c498cdb Compare May 6, 2025 07:45
@mgallien mgallien merged commit 595ffc7 into master May 6, 2025
12 of 15 checks passed
@mgallien mgallien deleted the bugfix/bundle-vfs-plugins-in-appimage branch May 6, 2025 07:45
@github-actions
Copy link

github-actions bot commented May 6, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8217.zip

SHA256 checksum: b1719f7fbc6e51cdd29f8bda87953e1c46104172530e682f287967844f734910

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nilsding nilsding linked an issue May 12, 2025 that may be closed by this pull request
[Bug]: Nextcloud 3.16.4 AppImage for Linux, crash when try to enable VFS #8261
Closed
8 tasks
@nilsding nilsding mentioned this pull request May 12, 2025
Closed
8 tasks
@nilsding
Copy link
Member Author

nilsding commented May 30, 2025

/backport to stable-3.16

@backportbot backportbot bot mentioned this pull request May 30, 2025
Merged
@derspotter
Copy link

derspotter commented Aug 25, 2025

I don't think this has worked. The issue this was supposed to address persists in the new release Nextcloud-3.17.1-x86_64.AppImage.

@nilsding
Copy link
Member Author

nilsding commented Aug 25, 2025

@derspotter please open another issue including logs related to the loading of VFS plugins

The 3.17.1 appimage contains usr/plugins/nextcloudsync_vfs_suffix.so at least ...

@derspotter derspotter mentioned this pull request Aug 25, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

Assignees

@nilsding nilsding

Labels

3. to review feature: 💽 virtual filesystem os: 🐧 Linux

Projects

None yet

Milestone

3.17.0

5 participants

@nilsding @derspotter @claucambra @mgallien