Skip to content

Conversation

@nilsding
Copy link
Member

@nilsding nilsding commented Jan 17, 2025

When setting up an account through the wizard for the first time, the credentials are not saved properly. This requires the user to sign in again after an application restart.

At least for the login flow v2 case, the WebFlowCredentials class eventually persists the retrieved credentials, whereas the class used within the wizard (OCC::Flow2AuthCredsPage) doesn't.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7768-34c51cc616f899ca3a4c586cc506f41f7acb3ce1-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding marked this pull request as ready for review January 22, 2025 10:03
@nilsding nilsding added this to the 3.16.0 milestone Jan 22, 2025
@nilsding nilsding mentioned this pull request Jan 23, 2025
When setting up an account through the wizard for the first time, the
credentials are not saved properly.  This requires the user to sign in
again after an application restart.

At least for the login flow v2 case, the `WebFlowCredentials` class
eventually persists the retrieved credentials, whereas the class used
within the wizard (`OCC::Flow2AuthCredsPage`) doesn't.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@mgallien mgallien force-pushed the bugfix/relogin-after-initial-setup-wizard branch from 34c51cc to 75fdfea Compare January 24, 2025 14:07
@mgallien mgallien merged commit 60a106c into master Jan 24, 2025
10 of 14 checks passed
@mgallien mgallien deleted the bugfix/relogin-after-initial-setup-wizard branch January 24, 2025 14:07
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7768.zip

SHA256 checksum: 456d08c71515355d9f97150e8b309b1a484bd2cf504aebcbba03a12ef5ee36ce

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants