Skip to content

Fix wrong null->0L conversion #13838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 4 commits into from
Oct 21, 2024
Merged

Fix wrong null->0L conversion #13838

tobiasKaminsky merged 4 commits into from
Oct 21, 2024

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Oct 21, 2024 •
edited
Loading

Fix #13738

  • Fix wrong null->0L conversion
  • add button to remove sync entries
  • Tests written, or not not needed

@tobiasKaminsky
Fix wrong null->0L conversion
5ddec7f 
add button to remove sync entries

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
x correct positioned
40ca0b1 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

github-actions bot commented Oct 21, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness6363
Dodgy code300300
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total514514

@ZetaTom
Skip root folder for two way sync
398a851 
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Oct 21, 2024

/backport to stable-3.30

@ZetaTom
Remove unnecessary LinearLayout
10a9681 
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
@tobiasKaminsky tobiasKaminsky merged commit eb75643 into master Oct 21, 2024
@tobiasKaminsky tobiasKaminsky deleted the fix0L branch October 21, 2024 14:48
@backportbot backportbot bot mentioned this pull request Oct 21, 2024
Merged
2 tasks
@ZetaTom ZetaTom mentioned this pull request Oct 21, 2024
Closed
4 tasks
@joshtrichards
Copy link
Member

joshtrichards commented Oct 21, 2024

Thanks to both of you for diving right into this today. It's much appreciated. And, uh, welcome back from vacation, Tobias. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZetaTom ZetaTom ZetaTom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unwanted syncing of all files w/ 3.30.1

4 participants

@tobiasKaminsky @joshtrichards @ZetaTom