feat(adapters): allow Account mapping before DB#5461
Closed
balazsorban44 wants to merge 4 commits intomainfrom
Closed
feat(adapters): allow Account mapping before DB#5461balazsorban44 wants to merge 4 commits intomainfrom
Account mapping before DB#5461balazsorban44 wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Member
Author
|
cc @palminha curious what you think. This would still introduce a new config option but would be already familiar since it's similar to the We could change the default value to It would align with the |
balazsorban44
commented
Sep 30, 2022
Comment on lines
+243
to
+259
| if (version?.startsWith("1")) { | ||
| return { | ||
| ...required, | ||
| oauth_token_secret: rest.oauth_token_secret, | ||
| oauth_token: rest.oauth_token, | ||
| } | ||
| } | ||
| return { | ||
| ...required, | ||
| access_token: rest.access_token, | ||
| token_type: rest.token_type, | ||
| id_token: rest.id_token, | ||
| refresh_token: rest.refresh_token, | ||
| scope: rest.scope, | ||
| expires_at: rest.expires_at, | ||
| session_state: rest.session_state, | ||
| } |
Member
Author
There was a problem hiding this comment.
These are the values currently in the default schemas.
19c6807 to
3be7bb7
Compare
Member
Author
|
Closing as discussed with @ThangHuuVu. With some minor changes, this will be part of |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative proposal to #4893
Right now, we pass through all the values of a provider account to the DB, and it causes confusion/unforeseen breaks when a provider decides to return a new property.
To solve this, we can add an
accountproperty to the provider configuration, similar to theprofilecallback, to control what part of the account should be saved to the database.Example:
Closes #4893