Skip to content

Replace node-oauth dependency #1048

@balazsorban44

Description

@balazsorban44

https://github.com/ciaranj/node-oauth Is a library we use to communicate with OAuth providers. Although it works, we have already patched it in many places, mainly because it uses callbacks over Promises, and the library itself looks abandoned. (Last commit was in 2017).

We should either get rid of it, or replace it fully.

node-openid-client looks like a nice alternative, but it does not seem to support OAuth 1.0.

We could add it now, and only utilize it for OAuth 2 and OIDC flows, and we could remove OAuth 1 support at a later point. (It would be a breaking change)

As far as I can tell, only the Twitter provider uses OAuth 1.

Ref: https://developer.twitter.com/en/docs/authentication/api-reference/token

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions