Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

Fixed refresh token example#117

Closed
agusterodin wants to merge 1 commit intonextauthjs:mainfrom
agusterodin:main
Closed

Fixed refresh token example#117
agusterodin wants to merge 1 commit intonextauthjs:mainfrom
agusterodin:main

Conversation

@agusterodin
Copy link
Copy Markdown

@agusterodin agusterodin commented Nov 14, 2021

Changes 💡

  1. Removed 'working example' repo link since it is outdated (doesn't work with v4). If you want to host the updated v4 example, here it is: next-auth-refresh-tokens.zip.
  2. Added required secret property to next-auth configuration since this particular example doesn't work without it and throws JWEDecryptionFailed: decryption operation failed at random times otherwise..

Affected issues 🎟

N/A, this was only mentioned here: nextauthjs/next-auth#3016

Screenshot (If Applicable) 📷

N/A

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/docs/3niLnKjJsdvUD71GDn1mZDWB43wT
✅ Preview: https://docs-git-fork-agusterodin-main-nextauthjs.vercel.app

@balazsorban44 balazsorban44 requested a review from ndom91 November 15, 2021 14:09
ndom91
ndom91 reviewed Nov 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ndom91 ndom91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw this PR looks good to me 👍

ndom91
ndom91 approved these changes Nov 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw this PR looks good to me!

@balazsorban44
Copy link
Copy Markdown
Member

balazsorban44 commented Nov 24, 2021

This is doing changes in the v3 adapter, which I think we should leave as-is. #130 adds this, and here is the code above https://github.com/nextauthjs/next-auth-refresh-token-example

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ndom91 ndom91 ndom91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@0ubbe 0ubbe

@ndom91 ndom91

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agusterodin @balazsorban44 @ndom91 @0ubbe