Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

add Initialization docs#109

Merged
balazsorban44 merged 3 commits into
mainfrom
init-instructions
Nov 10, 2021
Merged

add Initialization docs#109
balazsorban44 merged 3 commits into
mainfrom
init-instructions

Conversation

@balazsorban44

Copy link
Copy Markdown
Contributor

Based on a few questions, this documentation could be the source of truth when explaining how to do custom actions that are too specific to be included in the library.

Some related discussions:
nextauthjs/next-auth#3133
nextauthjs/next-auth#3156
nextauthjs/next-auth#2703

@balazsorban44 balazsorban44 requested review from 0ubbe and ndom91 November 8, 2021 21:00
@vercel

vercel Bot commented Nov 8, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/docs/6SWFWMZrktu1jzpVgR6ipbiw1rc8
✅ Preview: https://docs-git-init-instructions-nextauthjs.vercel.app

Comment thread docs/configuration/initialization.md Outdated
This way of initializing `NextAuth` is very powerful, but should be used sparingly.

:::warning
Changing parts of the request that is essential to `NextAuth` to do it's job - like messing with the [default cookies](http://localhost:3000/configuration/options#cookies) - can have unforeseen consequences, and have the potential to introduce security holes if done incorrectly. Only change those this if you understand these consequences.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Changing parts of the request that is essential to `NextAuth` to do it's job - like messing with the [default cookies](http://localhost:3000/configuration/options#cookies) - can have unforeseen consequences, and have the potential to introduce security holes if done incorrectly. Only change those this if you understand these consequences.
Changing parts of the request that is essential to `NextAuth` to do it's job - like messing with the [default cookies](/configuration/options#cookies) - can have unforeseen consequences, and have the potential to introduce security holes if done incorrectly. Only change those this if you understand these consequences.

@zakaryan2004 zakaryan2004 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! This will help a lot of users.

I'll test the provider idea again in my project and see if it works this way.

@ndom91 ndom91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me! I'm just gonna approve it, but I would either now or sometime later
before going live with v4 GA tighten up some of the copy. Some parts are a bit wordy and could be slightly confusing.

Great idea with this page though, its a super frequently asked about thing huh.

Comment thread docs/configuration/initialization.md Outdated
Comment thread docs/configuration/initialization.md Outdated
Comment thread docs/configuration/initialization.md Outdated
Comment thread docs/configuration/initialization.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants