Pull Request Test Coverage Report for Build 13869475438

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.451%

Totals
Change from base Build 13828410922:	0.0%
Covered Lines:	400
Relevant Lines:	405

💛 - Coveralls

@kemchenj There is a small side-effect caused by this pull request: The page:loaded event is not triggered as expected. The event is registered by source/js/utils.js, but if it's loaded with defer attribute, document.readyState === 'loading' on line 16 is always evaluated to false, and thus page:loaded event will be triggered immediately by onPageLoaded function on line 19.

However, the scripts loaded after utils.js are not executed (for example, fancybox.js), so the callback functions for page:loaded event in these scripts will never be called (because the callback functions are registered later than the event is triggered).
I tried to fix the issue in: 0a170b8
Can you help me confirm if the events and callback functions related to page loading and PJAX (including page:loaded, pjax:success and DOMContentLoaded) are still working after the changes of this pull request and my patch? Thanks!

@kemchenj There is a small side-effect caused by this pull request: The page:loaded event is not triggered as expected. The event is registered by source/js/utils.js, but if it's loaded with defer attribute, document.readyState === 'loading' on line 16 is always evaluated to false, and thus page:loaded event will be triggered immediately by onPageLoaded function on line 19.

hexo-theme-next/source/js/utils.js

Lines 9 to 22 in 01bc42c

	(function() {
	const onPageLoaded = () => document.dispatchEvent(
	new Event('page:loaded', {
	bubbles: true
	})
	);
	if (document.readyState === 'loading') {
	document.addEventListener('readystatechange', onPageLoaded, { once: true });
	} else {
	onPageLoaded();
	}
	document.addEventListener('pjax:success', onPageLoaded);
	})();

However, the scripts loaded after utils.js are not executed (for example, fancybox.js), so the callback functions for page:loaded event in these scripts will never be called (because the callback functions are registered later than the event is triggered). I tried to fix the issue in: 0a170b8 Can you help me confirm if the events and callback functions related to page loading and PJAX (including page:loaded, pjax:success and DOMContentLoaded) are still working after the changes of this pull request and my patch? Thanks!

Sure, I'll take a look at this weekend.

@kemchenj There is a small side-effect caused by this pull request: The page:loaded event is not triggered as expected. The event is registered by source/js/utils.js, but if it's loaded with defer attribute, document.readyState === 'loading' on line 16 is always evaluated to false, and thus page:loaded event will be triggered immediately by onPageLoaded function on line 19.

hexo-theme-next/source/js/utils.js

Lines 9 to 22 in 01bc42c

	(function() {
	const onPageLoaded = () => document.dispatchEvent(
	new Event('page:loaded', {
	bubbles: true
	})
	);
	if (document.readyState === 'loading') {
	document.addEventListener('readystatechange', onPageLoaded, { once: true });
	} else {
	onPageLoaded();
	}
	document.addEventListener('pjax:success', onPageLoaded);
	})();

However, the scripts loaded after utils.js are not executed (for example, fancybox.js), so the callback functions for page:loaded event in these scripts will never be called (because the callback functions are registered later than the event is triggered). I tried to fix the issue in: 0a170b8 Can you help me confirm if the events and callback functions related to page loading and PJAX (including page:loaded, pjax:success and DOMContentLoaded) are still working after the changes of this pull request and my patch? Thanks!

I've tested with my blog site, in both Safari and Chrome, with and without cache, they all works as expected.

But I can't find anywhere the page:loaded was passed to the addEventListener, but I could confirm that it was dispatched correctly.

@kemchenj Thanks! page:loaded is mostly used by some third-party plugins (e.g. MathJax and some comment systems).