Skip to content

Fix SCRIPT1028 caused by async#852

Merged
stevenjoezhang merged 1 commit intonext-theme:masterfrom
wherewhere:fix-edge
Dec 23, 2024
Merged

Fix SCRIPT1028 caused by async#852
stevenjoezhang merged 1 commit intonext-theme:masterfrom
wherewhere:fix-edge

Conversation

@wherewhere
Copy link
Contributor

PR Checklist

  • The changes have been tested (for bug fixes / features).
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (e.g. formatting, linting).
  • Refactoring (no changes to functionality and APIs).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved:

On Edge HTML writting like

const { async = false } = {}

will cause Expected identifier, string or number.

image

And it cannot be fixed by babel.

So just change it to

const async = a.async ?? false;

and it works fine.

@welcome
Copy link

welcome bot commented Nov 30, 2024

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2024

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang stevenjoezhang added this to the 8.22.0 milestone Nov 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12095435002

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.451%

Totals Coverage Status
Change from base Build 12056039421: 0.0%
Covered Lines: 400
Relevant Lines: 405

💛 - Coveralls

@stevenjoezhang stevenjoezhang merged commit da4712e into next-theme:master Dec 23, 2024
@welcome
Copy link

welcome bot commented Dec 23, 2024

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants