Feature: Duration Configuration to _config.yml and Update motion.js#846
Merged
stevenjoezhang merged 1 commit intonext-theme:masterfrom Nov 21, 2024
Merged
Conversation
|
Thanks so much for opening your first PR here! |
|
|
|
This pull request contains changes to the configuration file. Please make sure the documentation in NexT website is changed or added. |
Pull Request Test Coverage Report for Build 11828990925Details
💛 - Coveralls |
_config.yml and Update motion.js_config.yml and Update motion.js
|
Congrats on merging your first pull request here! 🎉 How awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Adjusting the duration required direct modification within
source/js/motion.js.What is the new behavior?
motion.durationconfiguration in_config.ymlto manage the motion duration setting conveniently.source/js/motion.jsto retrieve the duration value fromCONFIG.motion.duration, defaulting to200if not set.How to use?
In NexT
_config.yml:duration-120.mov
duration-200.mov