Skip to content

Supports customizing the width of the follow-me QR code#837

Merged
stevenjoezhang merged 2 commits intonext-theme:masterfrom
Jiajun-Peng:master
Mar 31, 2025
Merged

Supports customizing the width of the follow-me QR code#837
stevenjoezhang merged 2 commits intonext-theme:masterfrom
Jiajun-Peng:master

Conversation

@Jiajun-Peng
Copy link
Contributor

PR Checklist

  • The changes have been tested (for bug fixes / features).
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (e.g. formatting, linting).
  • Refactoring (no changes to functionality and APIs).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Under the current configuration, the WeChat QR code image is too small and cannot be scanned:
image-20240831204940929

When setting a larger max-width value, the following issues occur:
image-20240831212046068
image-20240831212708999

Because AddToAny Share button appears on top layer:
image-20240831212018720

Similarly, the comment component also prevents the WeChat QR code from displaying fully:
image-20240901083926322

Issue resolved:

What is the new behavior?

Improvement:
Snipaste_2024-09-01_10-30-48
image-20240901084257134

How to use?

In NexT _config.yml:

@welcome
Copy link

welcome bot commented Sep 1, 2024

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2024

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang stevenjoezhang added this to the 8.20.1 milestone Sep 3, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 14162536424

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.451%

Totals Coverage Status
Change from base Build 9517060757: 0.005%
Covered Lines: 400
Relevant Lines: 405

💛 - Coveralls

@stevenjoezhang
Copy link
Member

I'm concerned that hardcoding 460 pixels may not be suitable for all situations. Perhaps we should consider if there's a better approach.

@stevenjoezhang stevenjoezhang modified the milestones: 8.21.0, 8.21.1 Sep 20, 2024
@stevenjoezhang stevenjoezhang removed this from the 8.21.1 milestone Nov 3, 2024
@stevenjoezhang stevenjoezhang added this to the 8.22.1 milestone Mar 31, 2025
@stevenjoezhang stevenjoezhang changed the title Support displaying wider follow-me QR code images Supports customizing the width of the follow-me QR code Mar 31, 2025
@stevenjoezhang
Copy link
Member

I haven't found a better solution. Users may need to set the value of $post-followme-img-width themselves based on their specific situation.

@stevenjoezhang stevenjoezhang merged commit 5f4210f into next-theme:master Mar 31, 2025
11 checks passed
@welcome
Copy link

welcome bot commented Mar 31, 2025

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants