fix: normalize Gemini PDF URL to prevent /v1beta/v1beta duplication#64
Open
newtontech wants to merge 1 commit intomainfrom
Open
fix: normalize Gemini PDF URL to prevent /v1beta/v1beta duplication#64newtontech wants to merge 1 commit intomainfrom
newtontech wants to merge 1 commit intomainfrom
Conversation
…duplication Fixes openclaw#34312 - Added normalizeGeminiBaseUrl function to ensure /v1beta is present exactly once - Updated generateGeminiInlineDataText to use the new normalization function - Added comprehensive tests for URL construction edge cases - Prevents URL duplication when baseUrl already includes /v1beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes URL duplication issue where the Gemini PDF endpoint was constructed as
/v1beta/v1beta/models/...when the baseUrl already included/v1beta.Changes
normalizeGeminiBaseUrlfunction to ensure/v1betais present exactly once in the URLgenerateGeminiInlineDataTextto use the new normalization function/v1betaTesting
normalizeGeminiBaseUrlfunction/v1beta/models/{model}:generateContentFixes openclaw#34312