fix(cron): suppress delivery when any payload contains HEARTBEAT_OK#49
Open
newtontech wants to merge 1 commit intomainfrom
Open
fix(cron): suppress delivery when any payload contains HEARTBEAT_OK#49newtontech wants to merge 1 commit intomainfrom
newtontech wants to merge 1 commit intomainfrom
Conversation
Fixes openclaw#32130 Previously, isHeartbeatOnlyResponse() used .every() to check if ALL payloads were heartbeat tokens. This caused delivery to proceed when the agent emitted narration payloads before the final HEARTBEAT_OK. Changed to .some() so that if ANY payload contains HEARTBEAT_OK, the entire response is treated as a heartbeat ack and delivery is suppressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where HEARTBEAT_OK delivery suppression failed when cron agents emitted multiple text payloads.
Root Cause
The
isHeartbeatOnlyResponse()function used.every()to check if ALL payloads were heartbeat tokens. When agents emitted narration payloads before the final HEARTBEAT_OK, this check returned false, causing all payloads to be delivered to users.Changes
.every()to.some()insrc/cron/isolated-agent/helpers.tsTesting
Fixes openclaw#32130