fix: resolve Telegram slash command auth in forum topics#26
Open
newtontech wants to merge 16 commits intomainfrom
Open
fix: resolve Telegram slash command auth in forum topics#26newtontech wants to merge 16 commits intomainfrom
newtontech wants to merge 16 commits intomainfrom
Conversation
…tch (openclaw#27094) Fix tool-call lookup failures when models emit whitespace-padded names by normalizing both transcript history and live streamed embedded-runner tool calls before dispatch. Co-authored-by: wangchunyue <80630709+openperf@users.noreply.github.com> Co-authored-by: Sid <sidqin0410@gmail.com> Co-authored-by: Philipp Spiess <hello@philippspiess.com>
… thanks @rodrigouroz Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: rodrigouroz <384037+rodrigouroz@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
* Dependencies: make @discordjs/opus an optional peer * Dependencies: bump node-llama-cpp peer to 3.16.2 * Dependencies: pin Google auth deps to warning-free versions * CI: reduce Dependabot cooldown to 2 days * CI: fix invalid Dependabot npm registry config * CI: restore Dependabot npm registry with token auth * Dependencies: remove global Google auth pnpm overrides * CI: make Dependabot updates daily * Dependencies: restore optional install semantics for @discordjs/opus * CI: keep Docker Dependabot interval weekly
…nclaw#17874) * feat(memory-lancedb): add custom baseUrl and dimensions support * fix(memory-lancedb): strict model typing and safe dimension resolution * style: fix formatting in memory-lancedb config * fix(memory-lancedb): sync manifest schema with new embedding options --------- Co-authored-by: OpenClaw Bot <bot@openclaw.ai>
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <codingpunk@gmail.com> Co-authored-by: EdwardWu7 <wuzhiyuan7@gmail.com> Co-authored-by: MoerAI <friendnt@g.skku.edu>
Verified: - pnpm build - pnpm check - pnpm test:macmini (fails in this environment at src/daemon/launchd.integration.test.ts beforeAll hook timeout; merged with Tak override) Co-authored-by: rodrigouroz <384037+rodrigouroz@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
Land contributor PR openclaw#29032 by @maloqab with Slack native alias docs, integration tests, and changelog entry. Co-authored-by: maloqab <mitebaloqab@gmail.com>
- Remove trailing blank line after Jonathan Taylor entry - Escape underscore in @jlehman_ X handle Fixes openclaw#29039
…nclaw#26050) thanks @bmendonca3 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: bmendonca3 <208517100+bmendonca3@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
Forum topics use :topic:<threadId> suffixed session keys, but the command authorization check was not correctly resolving these session keys. This fix ensures CommandTargetSessionKey correctly handles forum topic context for native slash commands by using the already-resolved thread ID from the authorization flow instead of re-resolving it. Fixes openclaw#29135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Telegram slash commands returning 'not authorized' in forum topic chats.
Problem
Forum topics use
:topic:<threadId>suffixed session keys, but the command authorization check was not correctly resolving these session keys for native BotFather commands.Root Cause
The
resolveCommandRuntimeContextfunction was buildingthreadSpecusing the rawmessage_thread_idfrom the message instead of using the already-resolvedresolvedThreadIdfrom the authorization flow. WhileresolveTelegramThreadSpecinternally resolves the thread ID, this created unnecessary duplication and potential for inconsistency.Solution
Updated
resolveCommandRuntimeContextto buildthreadSpecdirectly using the already-resolvedresolvedThreadIdparameter, ensuring consistency with the authorization flow and correct handling of forum topic session keys.Changes
resolveCommandRuntimeContextto useresolvedThreadIddirectly instead of re-resolving itTelegramThreadSpecTesting
Fixes openclaw#29135