fix: respect renderMode config in Feishu outbound adapter#20
Open
newtontech wants to merge 3 commits intomainfrom
Open
fix: respect renderMode config in Feishu outbound adapter#20newtontech wants to merge 3 commits intomainfrom
newtontech wants to merge 3 commits intomainfrom
Conversation
…tch (openclaw#27094) Fix tool-call lookup failures when models emit whitespace-padded names by normalizing both transcript history and live streamed embedded-runner tool calls before dispatch. Co-authored-by: wangchunyue <80630709+openperf@users.noreply.github.com> Co-authored-by: Sid <sidqin0410@gmail.com> Co-authored-by: Philipp Spiess <hello@philippspiess.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an inconsistency where the
renderMode: "card"configuration was respected by reply messages but ignored by outbound messages in the Feishu extension.Problem
The
feishuOutbound.sendText()always calledsendMessageFeishu()which sendspost-type messages (using themdtag) regardless of therenderModeconfiguration. Themdtag does NOT support markdown tables.Meanwhile,
reply-dispatcher.tscorrectly checkedrenderModeand usedsendMarkdownCardFeishu()whenrenderMode === "card", which sendsinteractive-type messages (using themarkdowntag) that DO support markdown tables.This caused inconsistent behavior where:
renderMode: "card"was configuredopenclaw message send) could not render tables even with the same configurationChanges
extensions/feishu/src/outbound.ts:renderModeconfiguration checking in thesendText()methodrenderMode === "card", routes tosendMarkdownCardFeishu()instead ofsendMessageFeishu()reply-dispatcher.tsRelated Issue
Fixes openclaw#28616
Test Plan
renderMode: "card"openclaw message send --channel feishu --to "ou_xxx" "## 商品清单\n\n| 名称 | 数量 | 单价 |\n|:-----|------|:-----|\n| 苹果 | 10 | 3.5元 |"