newton/_src/viewer/viewer_file.py (1)

1243-1260: Sync Args: docs with the expanded log_mesh signature.

color, roughness, and metallic are now accepted but missing from the method’s documented arguments.

As per coding guidelines: "Follow Google-style docstrings with types in annotations, not docstrings. Use Args: with name: description format."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@newton/_src/viewer/viewer_file.py` around lines 1243 - 1260, Update the
log_mesh docstring Args section to include the new parameters introduced in the
signature: add entries for color, roughness, and metallic (using the
Google-style "param: description" format), and ensure their descriptions match
existing style for other args (e.g., color: Optional RGB tuple for mesh color;
roughness: Optional float controlling surface roughness; metallic: Optional
float controlling metalness). Keep types only in the function signature and not
in the docstring, and leave other argument descriptions unchanged to stay
consistent with the log_mesh function and surrounding docstring style.

newton/_src/viewer/viewer_viser.py (1)

411-429: Add missing Args: entries for new material parameters.

Please document color, roughness, and metallic in the log_mesh docstring (and note backend behavior if they are intentionally ignored here).

As per coding guidelines: "Follow Google-style docstrings with types in annotations, not docstrings. Use Args: with name: description format."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@newton/_src/viewer/viewer_viser.py` around lines 411 - 429, Update the
log_mesh docstring to include Args entries for the new material parameters: add
color, roughness, and metallic using the Google-style "name: description" format
(do not repeat types in the docstring), e.g. describe color as an RGB tuple
applied to the mesh, roughness and metallic as material properties in [0,1];
also state the backend behavior for these fields (e.g., "ignored by viser
backend" or "used by backend to set material properties") so callers know
whether these parameters will affect visualization; ensure the entries reference
the existing parameter names exactly (color, roughness, metallic) and keep the
rest of the docstring unchanged.

newton/_src/viewer/viewer_usd.py (1)

215-233: Document the new log_mesh parameters in Args:.

color, roughness, and metallic were added to the signature, but the Args: section does not describe them yet.

As per coding guidelines: "Follow Google-style docstrings with types in annotations, not docstrings. Use Args: with name: description format."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@newton/_src/viewer/viewer_usd.py` around lines 215 - 233, The Args section of
the docstring for log_mesh (the function with parameters color, roughness,
metallic) is missing descriptions for the newly added parameters; update the
Args: block to add lines for color: optional RGB tuple to tint the mesh,
roughness: optional float controlling PBR roughness, and metallic: optional
float controlling PBR metallicity, following the existing Google-style "name:
description" format and keeping types only in the signature.

newton/_src/viewer/viewer_rerun.py (1)

218-236: Keep the Args: block in sync with the new parameters.

The newly added color, roughness, and metallic parameters should be documented in this method’s docstring.

As per coding guidelines: "Follow Google-style docstrings with types in annotations, not docstrings. Use Args: with name: description format."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@newton/_src/viewer/viewer_rerun.py` around lines 218 - 236, The docstring
Args: block for the mesh-logging method is out of sync—add entries for the new
parameters color, roughness, and metallic using the Google-style "name:
description" format (do not repeat types); update the existing Args: section in
the same method docstring to include lines like "color: Description of RGB tuple
or None", "roughness: Description of optional roughness value", and "metallic:
Description of optional metallic value", ensuring the parameter names match the
function signature and keeping descriptions concise; leave type annotations to
the function signature and do not add types in the docstring.

newton/_src/viewer/viewer_null.py (1)

68-86: Update docstring Args: for the new signature.

Please add entries for color, roughness, and metallic so the no-op backend API docs remain complete.

As per coding guidelines: "Follow Google-style docstrings with types in annotations, not docstrings. Use Args: with name: description format."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@newton/_src/viewer/viewer_null.py` around lines 68 - 86, Update the docstring
for the no-op mesh method (the function with parameters color, roughness,
metallic — locate the method in viewer_null.py that accepts name, points,
indices, normals, uvs, texture, color, hidden, backface_culling, roughness,
metallic) to include Args entries for color, roughness, and metallic using the
Google-style "Args:" format (name: description) and do not include types in the
docstring; e.g., add lines describing color (optional RGB tuple to tint the
mesh), roughness (optional float controlling surface roughness), and metallic
(optional float controlling metallic property) alongside the existing entries
for name, points, indices, normals, uvs, texture, hidden, and backface_culling.

newton/_src/viewer/viewer_gl.py (1)

742-751: Validate color/PBR override inputs before applying them.

At Line 743, tuple indexing assumes exactly 3 channels and currently fails with a generic IndexError for malformed inputs; roughness/metallic are also documented as [0, 1] but not validated.

Proposed hardening patch

         if color is not None:
+            if len(color) != 3:
+                raise ValueError("color must be an RGB tuple of length 3")
+            if any((c < 0.0 or c > 1.0) for c in color):
+                raise ValueError("color values must be in [0, 1]")
             self.objects[name].color = (float(color[0]), float(color[1]), float(color[2]))
 
         if roughness is not None or metallic is not None:
             r, m, c, t = self.objects[name].material
             if roughness is not None:
+                if roughness < 0.0 or roughness > 1.0:
+                    raise ValueError("roughness must be in [0, 1]")
                 r = float(roughness)
             if metallic is not None:
+                if metallic < 0.0 or metallic > 1.0:
+                    raise ValueError("metallic must be in [0, 1]")
                 m = float(metallic)
             self.objects[name].material = (r, m, c, t)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@newton/_src/viewer/viewer_gl.py` around lines 742 - 751, Validate inputs
before assigning to self.objects[name].color and self.objects[name].material:
check that color is a sequence with at least 3 numeric entries (convert to
float) and either raise a clear ValueError or skip assignment for malformed
colors; for roughness and metallic validate they are numeric and clamp or reject
values outside [0,1] before updating r and m (use the existing r,m,c,t tuple
unpacking and reassign self.objects[name].material only after validation).
Ensure errors include the object name to aid debugging.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes