Bump warp-lang to 1.13.0 dev nightly by adenzler-nvidia · Pull Request #2528 · newton-physics/newton

adenzler-nvidia · 2026-04-22T08:16:33Z

Description

Reinstate the warp-lang nightly bump that was reverted in #2448, pointing at the latest nightly build 1.13.0.dev20260422.

Checklist

New or existing tests cover these changes
The documentation is up to date with these changes
CHANGELOG.md has been updated (if user-facing change)

Test plan

Rely on CI to validate the updated nightly against the existing test suite.

Summary by CodeRabbit

Chores
- Updated performance testing environment to use a runtime installer that can fetch pre-release binaries.
- Pinned the core runtime dependency to a specific development build in project configuration.
Documentation
- Improved API doc generation so constants wrapped by scalar-like types are detected and rendered more reliably.

Reinstate the nightly bump reverted in newton-physics#2448, pointing at the latest nightly build 1.13.0.dev20260422.

coderabbitai · 2026-04-22T08:16:44Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: fdf1f65c-5f70-40fe-a6ec-62943ef667c6

📥 Commits

Reviewing files that changed from the base of the PR and between 1e6c56c and 3896f24.

⛔ Files ignored due to path filters (1)

uv.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

asv.conf.json
pyproject.toml

✅ Files skipped from review due to trivial changes (2)

pyproject.toml
asv.conf.json

📝 Walkthrough

Walkthrough

ASV and project dependency pins change to a Warp pre-release (warp-lang==1.13.0.dev20260423 with --pre in ASV), and the docs API generator now detects Warp scalar wrappers via wp.types.is_scalar(value) before unwrapping .value.

Changes

Cohort / File(s)	Summary
Benchmark / dependency pins `asv.conf.json`, `pyproject.toml`	ASV install_command updated to use `warp-lang==1.13.0.dev20260423` with `--pre`; `pyproject.toml` dependency pin changed from `>=1.12.0` to `==1.13.0.dev20260423`.
Docs API generator `docs/generate_api.py`	Constant scalar detection replaced `type(value) in wp.types.scalar_types` with `wp.types.is_scalar(value)` prior to accessing `.value`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Bump warp-lang to 1.13.0 dev nightly #2427: Also updates warp-lang pins and ASV install to use a 1.13.0 dev pre-release (same dev build transition).
Revert warp-lang 1.13.0 dev nightly bump #2448: Modifies the same asv/warp-lang version pin (related version pin changes/conflicts).

Suggested reviewers

shi-eric
gdaviet
Kenny-Vilella

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: bumping warp-lang dependency to version 1.13.0 dev nightly, which is reflected across all three modified files (asv.conf.json, pyproject.toml, and docs/generate_api.py reference).
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-04-22T08:37:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

warp-lang 1.13.0 dev removed wp.types.scalar_types. Use the new wp.types.is_scalar() helper, which has equivalent behaviour.

…nightly-bump

Nightly dev20260422 introduces a deterministic SIGSEGV / double-free in the CPU path under graph capture, reproducing across Linux, macOS, Windows, and the CI GPU runner's CPU leg. The crash occurs during garbage collection while mujoco_warp is inside a warp.capture_while region, with stack frames landing in warp._src.context / _src.types. Only dev20260422 is affected; dev20260421 runs the full suite cleanly. Suspected upstream regression: omniverse/warp d11116fc "Add graph capture for APIC serialization and CPU replay [newton-physicsGH-1349]", which is the only newly-included commit in dev20260422 that touches capture machinery on the CPU path. Pin exactly to dev20260421 until a fixed nightly lands; also tighten from >=1.12.0 to the exact nightly to prevent accidental upgrades to the broken build.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Around line 30-32: Replace the exact equality pin for warp-lang in
project.dependencies with a minimum-compatible or ranged constraint (e.g. change
"warp-lang==1.13.0.dev20260421" to a minimum like
"warp-lang>=1.13.0.dev20260421" or a ranged form excluding a broken build such
as "warp-lang>=1.13.0.dev20260421,!=1.13.0.dev20260422") to avoid forcing
downstream installs to a single nightly, and add a user-facing CHANGELOG.md
entry under the [Unreleased] → Changed section in imperative present tense (for
example: “Bump `warp-lang` requirement to `1.13.0.dev20260421`” plus any
migration notes) so the runtime bump is documented.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 1754669e-d06c-428d-81ff-16bcc57ee376

📥 Commits

Reviewing files that changed from the base of the PR and between f694697 and 1e6c56c.

⛔ Files ignored due to path filters (1)

uv.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

asv.conf.json
pyproject.toml

🚧 Files skipped from review as they are similar to previous changes (1)

asv.conf.json

Dev20260422 regressed the CPU path under graph capture (see prior commit). Advance the pin to the latest nightly to pick up fixes and stay current with upstream warp.

…nightly-bump

Bump warp-lang to 1.13.0 dev nightly

a0b698f

Reinstate the nightly bump reverted in newton-physics#2448, pointing at the latest nightly build 1.13.0.dev20260422.

adenzler-nvidia added 3 commits April 22, 2026 10:39

Fix generate_api.py for warp-lang nightly API change

f694697

warp-lang 1.13.0 dev removed wp.types.scalar_types. Use the new wp.types.is_scalar() helper, which has equivalent behaviour.

Merge remote-tracking branch 'upstream/main' into adenzler/warp-lang-…

e64c90d

…nightly-bump

coderabbitai Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread pyproject.toml

adenzler-nvidia mentioned this pull request Apr 22, 2026

Fix wp.tid() / launch-dim mismatches exposed by warp-lang 1.13 templated launch_bounds #2546

Merged

3 tasks

adenzler-nvidia added 2 commits April 23, 2026 10:06

Bump warp-lang pin to 1.13.0.dev20260423

3896f24

Dev20260422 regressed the CPU path under graph capture (see prior commit). Advance the pin to the latest nightly to pick up fixes and stay current with upstream warp.

Merge remote-tracking branch 'upstream/main' into adenzler/warp-lang-…

a7740d2

…nightly-bump

adenzler-nvidia requested a review from nvtw April 23, 2026 09:08

nvtw approved these changes Apr 23, 2026

View reviewed changes

adenzler-nvidia added this pull request to the merge queue Apr 23, 2026

Merged via the queue into newton-physics:main with commit 0b9b14a Apr 23, 2026
25 checks passed

coderabbitai Bot mentioned this pull request Apr 24, 2026

Bump warp-lang to 1.13.0rc1 #2570

Merged

3 tasks

adenzler-nvidia mentioned this pull request Apr 24, 2026

Install ASV comparison wheels from nvidia index #2573

Merged

3 tasks

coderabbitai Bot mentioned this pull request May 5, 2026

Bump warp-lang to 1.13.0 #2722

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump warp-lang to 1.13.0 dev nightly#2528

Bump warp-lang to 1.13.0 dev nightly#2528
adenzler-nvidia merged 6 commits into
newton-physics:mainfrom
adenzler-nvidia:adenzler/warp-lang-nightly-bump

adenzler-nvidia commented Apr 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

codecov Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adenzler-nvidia commented Apr 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

codecov Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adenzler-nvidia commented Apr 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading

codecov Bot commented Apr 22, 2026 •

edited

Loading