Skip to content

ParallelContext bbs memory leaks#3563

Merged
nrnhines merged 11 commits into
masterfrom
hines/pyretleak
Sep 9, 2025
Merged

ParallelContext bbs memory leaks#3563
nrnhines merged 11 commits into
masterfrom
hines/pyretleak

Conversation

@nrnhines

@nrnhines nrnhines commented Aug 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #3561

Notes:
Args were reversed when pycall executed for pc.submit(pycall, *args) introduced into Version 9. Fixed by f721d61
There was a doc typo with regard to NRN_OVERRIDE_LD_PRELOAD. Fixed by 8fccebb

@nrnhines nrnhines changed the title Hines/pyretleak ParallelContext bbs memory leaks Aug 9, 2025
@nrnhines nrnhines marked this pull request as draft August 9, 2025 11:16
@github-actions

github-actions Bot commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

✔️ f721d61 -> artifacts URL

@azure-pipelines

azure-pipelines Bot commented Aug 9, 2025

Copy link
Copy Markdown

✔️ f721d61 -> Azure artifacts URL

@codecov

codecov Bot commented Aug 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.51%. Comparing base (28d3612) to head (279c28e).
⚠️ Report is 43 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3563      +/-   ##
==========================================
+ Coverage   68.46%   68.51%   +0.05%     
==========================================
  Files         686      686              
  Lines      116758   116763       +5     
==========================================
+ Hits        79942    80006      +64     
+ Misses      36816    36757      -59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 24, 2025

Copy link
Copy Markdown
Contributor

✔️ 6469113 -> artifacts URL

@azure-pipelines

azure-pipelines Bot commented Aug 24, 2025

Copy link
Copy Markdown

✔️ 6469113 -> Azure artifacts URL

JCGoran
JCGoran reviewed Sep 4, 2025
View reviewed changes
Comment thread test/hoctests/tests/test_pyret.py
@github-actions

github-actions Bot commented Sep 6, 2025

Copy link
Copy Markdown
Contributor

✔️ 348f9d0 -> artifacts URL

@github-actions

github-actions Bot commented Sep 6, 2025

Copy link
Copy Markdown
Contributor

✔️ aa3d5ab -> artifacts URL

@azure-pipelines

azure-pipelines Bot commented Sep 6, 2025

Copy link
Copy Markdown

✔️ 348f9d0 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Sep 8, 2025

Copy link
Copy Markdown

✔️ b9c0690 -> Azure artifacts URL

@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

✔️ b9c0690 -> artifacts URL

@nrnhines nrnhines marked this pull request as ready for review September 8, 2025 11:33
@nrnhines nrnhines requested a review from JCGoran September 8, 2025 11:38
@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

✔️ 1ec4253 -> artifacts URL

@azure-pipelines

azure-pipelines Bot commented Sep 8, 2025

Copy link
Copy Markdown

✔️ 1ec4253 -> Azure artifacts URL

nrnhines
nrnhines commented Sep 8, 2025
View reviewed changes
Comment thread src/parallel/ocbbs.cpp
@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

✔️ 5bf6229 -> artifacts URL

@azure-pipelines

azure-pipelines Bot commented Sep 8, 2025

Copy link
Copy Markdown

✔️ 5bf6229 -> Azure artifacts URL

JCGoran
JCGoran reviewed Sep 9, 2025
View reviewed changes
Comment thread test/hoctests/tests/test_pyret.py
JCGoran
JCGoran approved these changes Sep 9, 2025
View reviewed changes

@JCGoran JCGoran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it fixes the issue, and ASAN is not reporting issues, I think we can move this along. You can optionally open a ticket for refactoring the refcounting to use shared_ptr instead of doing it manually.

@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

✔️ 4dcba32 -> artifacts URL

@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

✔️ 279c28e -> artifacts URL

@azure-pipelines

azure-pipelines Bot commented Sep 9, 2025

Copy link
Copy Markdown

✔️ 279c28e -> Azure artifacts URL

@nrnhines nrnhines merged commit 22a361f into master Sep 9, 2025
43 checks passed
@nrnhines nrnhines deleted the hines/pyretleak branch September 9, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgeplf mgeplf mgeplf left review comments
@JCGoran JCGoran JCGoran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PythonObject memory leak for pc.pyret()

3 participants

@nrnhines @mgeplf @JCGoran