Skip to content

Replaced % string formatting with f-strings#3552

Merged
ramcdougal merged 3 commits into
masterfrom
fstring
Aug 5, 2025
Merged

Replaced % string formatting with f-strings#3552
ramcdougal merged 3 commits into
masterfrom
fstring

Conversation

@ramcdougal

Copy link
Copy Markdown
Member

This was suggested in #3395

@ramcdougal ramcdougal requested review from adamjhn and noahsafar July 31, 2025 19:21
Comment thread share/lib/python/neuron/doc.py
Comment thread share/lib/python/neuron/doc.py
@azure-pipelines

Copy link
Copy Markdown

✔️ 7820722 -> Azure artifacts URL

@github-actions

Copy link
Copy Markdown
Contributor

✔️ 7820722 -> artifacts URL

@codecov

codecov Bot commented Jul 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.76923% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.40%. Comparing base (b3c52a0) to head (4fba5ed).
⚠️ Report is 55 commits behind head on master.

Files with missing lines Patch % Lines
share/lib/python/neuron/rxd/gui.py 0.00% 21 Missing ⚠️
share/lib/python/neuron/rxd/rxdmath.py 36.00% 16 Missing ⚠️
share/lib/python/neuron/coreneuron.py 28.57% 10 Missing ⚠️
share/lib/python/neuron/__init__.py 25.00% 9 Missing ⚠️
share/lib/python/neuron/rxd/geometry.py 12.50% 7 Missing ⚠️
share/lib/python/neuron/gui2/plotshape.py 0.00% 5 Missing ⚠️
share/lib/python/neuron/rxd/node.py 33.33% 4 Missing ⚠️
share/lib/python/neuron/doc.py 40.00% 3 Missing ⚠️
share/lib/python/neuron/rxd/rxd.py 82.35% 3 Missing ⚠️
share/lib/python/neuron/tests/test_neuron.py 0.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3552   +/-   ##
=======================================
  Coverage   68.40%   68.40%           
=======================================
  Files         684      684           
  Lines      116658   116646   -12     
=======================================
- Hits        79797    79790    -7     
+ Misses      36861    36856    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@noahsafar noahsafar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Comment thread share/lib/python/neuron/__init__.py Outdated
@github-actions

github-actions Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

✔️ 9982631 -> artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ 9982631 -> Azure artifacts URL

Comment thread share/lib/python/neuron/rxd/rxdmath.py Outdated
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2025

Copy link
Copy Markdown

@ramcdougal ramcdougal enabled auto-merge (squash) August 5, 2025 00:26
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

✔️ 4fba5ed -> artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ 4fba5ed -> Azure artifacts URL

@ramcdougal ramcdougal merged commit 91bd82f into master Aug 5, 2025
41 checks passed
@ramcdougal ramcdougal deleted the fstring branch August 5, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants